Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt to allow dependabot updates for almost all dependencies. #1003

Closed
wants to merge 1 commit into from

Conversation

mkuthan
Copy link
Member

@mkuthan mkuthan commented Dec 20, 2022

Let's try with updates for almost all dependencies. I defined a few ignore rules for problematic dependencies, perhaps there are many more. We'll see.

In general I defined lock on semver-major, but for 0.x.y dependencies like plywood or axios I put also semver-minor as ignored update type. If you see a better way to manage ignores, let me know in the comment.

I was especially surprised when I tried to update @type/node to 16.x. I thought that it should be in sync with Node version but I was wrong. I got dozen of errors from the TS transpiler.

@mkuthan mkuthan requested a review from a team as a code owner December 20, 2022 07:39
@github-actions
Copy link

⏱️ Lighthouse report

@github-actions
Copy link

size-limit report 📦

Path Size
build/public/main.js 1.74 MB (0%)
build/public/polyfills.es5.js 42.71 KB (0%)
build/public/dnd.es5.js 4.61 KB (0%)

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-dependabot-allow-all-gmbbyye42a-ew.a.run.app

@adrianmroz-allegro
Copy link
Contributor

I was especially surprised when I tried to update @type/node to 16.x. I thought that it should be in sync with Node version but I was wrong. I got dozen of errors from the TS transpiler.

Probably types for node 16 assume newer version of typescript and use some features that we don't have in our typescript compiler.

Copy link
Contributor

@adrianmroz-allegro adrianmroz-allegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's play with it!

@mkuthan mkuthan closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants